Update Suggested change

src/scripts/itembynamedetailpage.js

@@ -312,19 +312,17 @@ define(["connectionManager", "listView", "cardBuilder", "imageLoader", "libraryB
     }
 
     function addCurrentItemToQuery(query, item) {
-        if ("Person" == item.Type) {
+        if (item.Type == "Person") {
             query.PersonIds = item.Id;
-        } else {
+        } else if (item.Type == "Genre") {
-            if ("Genre" == item.Type) {
+            query.Genres = item.Name;
-                query.GenreIds = item.Id;
+        } else if (item.Type == "MusicGenre") {
-            } else {
+            query.Genres = item.Name;
-                if ("MusicGenre" == item.Type) {
+        } else if (item.Type == "GameGenre") {
-                    query.GenreIds = item.Id;
+            query.Genres = item.Name;
-                } else {
+        } else if (item.Type == "Studio") {
-                    if ("Studio" == item.Type) {
             query.StudioIds = item.Id;
-                    } else {
+        } else if (item.Type == "MusicArtist") {
-                        if ("MusicArtist" == item.Type) {
             if (connectionManager.getApiClient(item.ServerId).isMinServerVersion("3.4.1.18")) {
                 query.AlbumArtistIds = item.Id;
             } else {
@@ -332,10 +330,6 @@ define(["connectionManager", "listView", "cardBuilder", "imageLoader", "libraryB
             }
         }
     }
-                }
-            }
-        }
-    }
 
     function getQuery(options, item) {
         var query = {

src/scripts/librarybrowser.js

@@ -156,11 +156,10 @@ define(["userSettings"], function (userSettings) {
                 html += '<h2 style="margin:0 0 .5em;">';
                 html += Globalize.translate("HeaderSortBy");
                 html += "</h2>";
-                var i;
+                var i, length;
-                var length;
                 var isChecked;
-
+                html += '<div>';
-                for (html += "<div>", i = 0, length = options.items.length; i < length; i++) {
+                for (i = 0, length = options.items.length; i < length; i++) {
                     var option = options.items[i];
                     var radioValue = option.id.replace(",", "_");
                     isChecked = (options.query.SortBy || "").replace(",", "_") == radioValue ? " checked" : "";

src/scripts/librarymenu.js

@@ -206,8 +206,9 @@ define(["dom", "layoutManager", "inputManager", "connectionManager", "events", "
 
             html += '<a is="emby-linkbutton" class="navMenuOption lnkMediaFolder btnLogout" data-itemid="logout" href="#"><i class="md-icon navMenuOptionIcon">exit_to_app</i><span class="navMenuOptionText">' + globalize.translate("ButtonSignOut") + "</span></a>";
             html += "</div>";
-        } // add buttons to navigation drawer
+        }
 
+        // add buttons to navigation drawer
 
         navDrawerScrollContainer.innerHTML = html; // bind logout button click to method
 
@@ -501,8 +502,9 @@ define(["dom", "layoutManager", "inputManager", "connectionManager", "events", "
             showBySelector(".libraryMenuDownloads", false);
             showBySelector(".lnkSyncToOtherDevices", false);
             return void showBySelector(".userMenuOptions", false);
-        } // FIXME: Potentially the same as above
+        }
 
+        // FIXME: Potentially the same as above
 
         if (user.Policy.EnableContentDownloading) {
             showBySelector(".lnkSyncToOtherDevices", true);

src/scripts/livetvcomponents.js

@@ -6,11 +6,7 @@ define(["layoutManager", "datetime", "cardBuilder", "apphost"], function (layout
     }
 
     function getBackdropShape() {
-        if (enableScrollX()) {
+        return enableScrollX() ? 'overflowBackdrop' : 'backdrop';
-            return "overflowBackdrop";
-        }
-
-        return "backdrop";
     }
 
     function getTimersHtml(timers, options) {
@@ -29,7 +25,7 @@ define(["layoutManager", "datetime", "cardBuilder", "apphost"], function (layout
             var item = items[i];
             var dateText = "";
 
-            if (false !== options.indexByDate && item.StartDate) {
+            if (options.indexByDate !== false && item.StartDate) {
                 try {
                     var premiereDate = datetime.parseISO8601Date(item.StartDate, true);
                     dateText = datetime.toLocaleDateString(premiereDate, {
@@ -69,7 +65,12 @@ define(["layoutManager", "datetime", "cardBuilder", "apphost"], function (layout
             var supportsImageAnalysis = appHost.supports("imageanalysis");
             var cardLayout = appHost.preferVisualCards || supportsImageAnalysis;
 
-            if (cardLayout = true, group.name && (html += '<div class="verticalSection">', html += '<h2 class="sectionTitle sectionTitle-cards padded-left">' + group.name + "</h2>"), enableScrollX()) {
+            cardLayout = true;
+            if (group.name) {
+                html += '<div class="verticalSection">';
+                html += '<h2 class="sectionTitle sectionTitle-cards padded-left">' + group.name + "</h2>";
+            }
+            if (enableScrollX()) {
                 var scrollXClass = "scrollX hiddenScrollX";
 
                 if (layoutManager.tv) {

src/scripts/playlists.js

@@ -85,29 +85,38 @@ define(["loading", "listView", "cardBuilder", "libraryMenu", "libraryBrowser", "
                 });
 
                 if (result.TotalRecordCount) {
-                    html = "List" == viewStyle ? listView.getListViewHtml({
+                    if (viewStyle == "List") {
+                        html = listView.getListViewHtml({
                             items: result.Items,
                             sortBy: query.SortBy
-                    }) : "PosterCard" == viewStyle ? cardBuilder.getCardsHtml({
+                        });
+                    } else if (viewStyle == "PosterCard") {
+                        html = cardBuilder.getCardsHtml({
                             items: result.Items,
                             shape: "square",
                             coverImage: true,
                             showTitle: true,
                             cardLayout: true
-                    }) : "Thumb" == viewStyle ? cardBuilder.getCardsHtml({
+                        });
+                    } else if (viewStyle == "Thumb") {
+                        html = cardBuilder.getCardsHtml({
                             items: result.Items,
                             shape: "backdrop",
                             showTitle: true,
                             centerText: true,
                             preferThumb: true,
                             overlayPlayButton: true
-                    }) : "ThumbCard" == viewStyle ? cardBuilder.getCardsHtml({
+                        });
+                    } else if (viewStyle == "ThumbCard") {
+                        html = cardBuilder.getCardsHtml({
                             items: result.Items,
                             shape: "backdrop",
                             showTitle: true,
                             preferThumb: true,
                             cardLayout: true
-                    }) : cardBuilder.getCardsHtml({
+                        });
+                    } else {
+                        html = cardBuilder.getCardsHtml({
                             items: result.Items,
                             shape: "square",
                             showTitle: true,
@@ -115,6 +124,7 @@ define(["loading", "listView", "cardBuilder", "libraryMenu", "libraryBrowser", "
                             centerText: true,
                             overlayPlayButton: true
                         });
+                    }
                     view.querySelector(".noItemsMessage").classList.add("hide");
                 } else {
                     view.querySelector(".noItemsMessage").classList.remove("hide");

src/scripts/taskbutton.js

@@ -13,8 +13,19 @@ define(["events", "userSettings", "serverNotifications", "connectionManager", "e
                 return t.Key == options.taskKey;
             })[0];
 
-            if (options.panel && (task ? options.panel.classList.remove("hide") : options.panel.classList.add("hide")), task) {
+            if (options.panel) {
-                if ("Idle" == task.State) {
+                if (task) {
+                    options.panel.classList.remove('hide');
+                } else {
+                    options.panel.classList.add('hide');
+                }
+            }
+
+            if (!task) {
+                return;
+            }
+
+            if (task.State == 'Idle') {
                 button.removeAttribute("disabled");
             } else {
                 button.setAttribute("disabled", "disabled");
@@ -23,25 +34,30 @@ define(["events", "userSettings", "serverNotifications", "connectionManager", "e
             button.setAttribute("data-taskid", task.Id);
             var progress = (task.CurrentProgressPercentage || 0).toFixed(1);
 
-                if (options.progressElem && (options.progressElem.value = progress, "Running" == task.State ? options.progressElem.classList.remove("hide") : options.progressElem.classList.add("hide")), options.lastResultElem) {
+            if (options.progressElem) {
-                    var lastResult = task.LastExecutionResult ? task.LastExecutionResult.Status : "";
+                options.progressElem.value = progress;
 
-                    if ("Failed" == lastResult) {
+                if (task.State == 'Running') {
-                        options.lastResultElem.html('<span style="color:#FF0000;">(' + Globalize.translate("LabelFailed") + ")</span>");
+                    options.progressElem.classList.remove('hide');
                 } else {
-                        if ("Cancelled" == lastResult) {
+                    options.progressElem.classList.add('hide');
-                            options.lastResultElem.html('<span style="color:#0026FF;">(' + Globalize.translate("LabelCancelled") + ")</span>");
+                }
-                        } else {
+            }
-                            if ("Aborted" == lastResult) {
+
-                                options.lastResultElem.html('<span style="color:#FF0000;">' + Globalize.translate("LabelAbortedByServerShutdown") + "</span>");
+            if (options.lastResultElem) {
+                var lastResult = task.LastExecutionResult ? task.LastExecutionResult.Status : '';
+
+                if (lastResult == "Failed") {
+                    options.lastResultElem.html('<span style="color:#FF0000;">(' + Globalize.translate('LabelFailed') + ')</span>');
+                } else if (lastResult == "Cancelled") {
+                    options.lastResultElem.html('<span style="color:#0026FF;">(' + Globalize.translate('LabelCancelled') + ')</span>');
+                } else if (lastResult == "Aborted") {
+                    options.lastResultElem.html('<span style="color:#FF0000;">' + Globalize.translate('LabelAbortedByServerShutdown') + '</span>');
                 } else {
                     options.lastResultElem.html(lastResult);
                 }
             }
         }
-                }
-            }
-        }
 
         function onScheduledTaskMessageConfirmed(id) {
             connectionManager.getApiClient(serverId).startScheduledTask(id).then(pollTasks);
@@ -71,7 +87,7 @@ define(["events", "userSettings", "serverNotifications", "connectionManager", "e
             options.panel.classList.add("hide");
         }
 
-        if ("off" == options.mode) {
+        if (options.mode == 'off') {
             button.removeEventListener("click", onButtonClick);
             events.off(serverNotifications, "ScheduledTasksInfo", onScheduledTasksUpdate);