diff --git a/.eslintrc.js b/.eslintrc.js
index b78b730950..324f3d3e44 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -193,8 +193,6 @@ module.exports = {
'DlnaProfilePage': 'writable',
'DashboardPage': 'writable',
'Emby': 'readonly',
- 'getParameterByName': 'writable',
- 'getWindowLocationSearch': 'writable',
'Globalize': 'writable',
'Hls': 'writable',
'dfnshelper': 'writable',
diff --git a/src/components/appRouter.js b/src/components/appRouter.js
index 4e45f343c8..ce10d6e93a 100644
--- a/src/components/appRouter.js
+++ b/src/components/appRouter.js
@@ -120,7 +120,7 @@ class AppRouter {
const regexS = '[\\?&]' + name + '=([^]*)';
const regex = new RegExp(regexS, 'i');
- const results = regex.exec(url || getWindowLocationSearch());
+ const results = regex.exec(url || window.location.search);
if (results == null) {
return '';
} else {
@@ -678,19 +678,6 @@ class AppRouter {
};
}
- getWindowLocationSearch() {
- const currentPath = this.currentRouteInfo ? (this.currentRouteInfo.path || '') : '';
-
- const index = currentPath.indexOf('?');
- let search = '';
-
- if (index !== -1) {
- search = currentPath.substring(index);
- }
-
- return search || '';
- }
-
showGuide() {
Dashboard.navigate('livetv.html?tab=1');
}
diff --git a/src/components/favoriteitems.js b/src/components/favoriteitems.js
index 4230217429..7fd4baa5d0 100644
--- a/src/components/favoriteitems.js
+++ b/src/components/favoriteitems.js
@@ -5,6 +5,7 @@ import { appHost } from './apphost';
import imageLoader from './images/imageLoader';
import globalize from '../scripts/globalize';
import layoutManager from './layoutManager';
+import { getParameterByName } from '../utils/url.ts';
import '../assets/css/scrollstyles.scss';
import '../elements/emby-itemscontainer/emby-itemscontainer';
diff --git a/src/controllers/dashboard/devices/device.js b/src/controllers/dashboard/devices/device.js
index 607986c7f3..e2f000fef5 100644
--- a/src/controllers/dashboard/devices/device.js
+++ b/src/controllers/dashboard/devices/device.js
@@ -3,6 +3,7 @@ import dom from '../../../scripts/dom';
import '../../../elements/emby-input/emby-input';
import '../../../elements/emby-button/emby-button';
import Dashboard from '../../../scripts/clientUtils';
+import { getParameterByName } from '../../../utils/url.ts';
/* eslint-disable indent */
diff --git a/src/controllers/dashboard/dlna/profile.js b/src/controllers/dashboard/dlna/profile.js
index 00088cb6b6..4fd2f6415b 100644
--- a/src/controllers/dashboard/dlna/profile.js
+++ b/src/controllers/dashboard/dlna/profile.js
@@ -9,6 +9,7 @@ import '../../../elements/emby-checkbox/emby-checkbox';
import '../../../components/listview/listview.scss';
import Dashboard from '../../../scripts/clientUtils';
import toast from '../../../components/toast/toast';
+import { getParameterByName } from '../../../utils/url.ts';
/* eslint-disable indent */
diff --git a/src/controllers/dashboard/notifications/notification/index.js b/src/controllers/dashboard/notifications/notification/index.js
index 2b562ea073..8c3325c579 100644
--- a/src/controllers/dashboard/notifications/notification/index.js
+++ b/src/controllers/dashboard/notifications/notification/index.js
@@ -2,6 +2,7 @@ import escapeHtml from 'escape-html';
import 'jquery';
import '../../../../elements/emby-checkbox/emby-checkbox';
import Dashboard from '../../../../scripts/clientUtils';
+import { getParameterByName } from '../../../../utils/url.ts';
function fillItems(elem, items, cssClass, idPrefix, currentList, isEnabledList) {
let html = '
';
diff --git a/src/controllers/dashboard/scheduledtasks/scheduledtask.js b/src/controllers/dashboard/scheduledtasks/scheduledtask.js
index bd11ed3ca6..c326a689fc 100644
--- a/src/controllers/dashboard/scheduledtasks/scheduledtask.js
+++ b/src/controllers/dashboard/scheduledtasks/scheduledtask.js
@@ -7,6 +7,7 @@ import '../../../elements/emby-input/emby-input';
import '../../../elements/emby-button/emby-button';
import '../../../elements/emby-select/emby-select';
import confirm from '../../../components/confirm/confirm';
+import { getParameterByName } from '../../../utils/url.ts';
/* eslint-disable indent */
diff --git a/src/controllers/livetvguideprovider.js b/src/controllers/livetvguideprovider.js
index ecdb186e9f..ea7c35d332 100644
--- a/src/controllers/livetvguideprovider.js
+++ b/src/controllers/livetvguideprovider.js
@@ -2,6 +2,7 @@ import { Events } from 'jellyfin-apiclient';
import loading from '../components/loading/loading';
import globalize from '../scripts/globalize';
import Dashboard, { pageIdOn } from '../scripts/clientUtils';
+import { getParameterByName } from '../utils/url.ts';
function onListingsSubmitted() {
Dashboard.navigate('livetvstatus.html');
diff --git a/src/controllers/livetvtuner.js b/src/controllers/livetvtuner.js
index 4d2ecb738e..18e4d83721 100644
--- a/src/controllers/livetvtuner.js
+++ b/src/controllers/livetvtuner.js
@@ -6,6 +6,7 @@ import '../elements/emby-button/emby-button';
import '../elements/emby-checkbox/emby-checkbox';
import '../elements/emby-select/emby-select';
import Dashboard from '../scripts/clientUtils';
+import { getParameterByName } from '../utils/url.ts';
function isM3uVariant(type) {
return ['nextpvr'].indexOf(type || '') !== -1;
diff --git a/src/scripts/clientUtils.js b/src/scripts/clientUtils.js
index ac50e57c5a..6d4e3be683 100644
--- a/src/scripts/clientUtils.js
+++ b/src/scripts/clientUtils.js
@@ -112,7 +112,7 @@ export function navigate(url, preserveQueryString) {
throw new Error('url cannot be null or empty');
}
- const queryString = getWindowLocationSearch();
+ const queryString = window.location.search;
if (preserveQueryString && queryString) {
url += queryString;
diff --git a/src/scripts/editorsidebar.js b/src/scripts/editorsidebar.js
index 55a90f9d04..220597d64e 100644
--- a/src/scripts/editorsidebar.js
+++ b/src/scripts/editorsidebar.js
@@ -3,6 +3,7 @@ import 'jquery';
import globalize from './globalize';
import 'material-design-icons-iconfont';
import Dashboard from './clientUtils';
+import { getParameterByName } from '../utils/url.ts';
/* eslint-disable indent */
@@ -299,9 +300,9 @@ import Dashboard from './clientUtils';
if (itemId) {
return itemId;
}
- const url = window.location.hash || window.location.href;
- return getParameterByName('id', url);
+ return getParameterByName('id');
}
+
let nodesToLoad = [];
let selectedNodeId;
$(document).on('itemsaved', '.metadataEditorPage', function (e, item) {
diff --git a/src/scripts/libraryMenu.js b/src/scripts/libraryMenu.js
index f4051ea83c..7bf5cad478 100644
--- a/src/scripts/libraryMenu.js
+++ b/src/scripts/libraryMenu.js
@@ -19,6 +19,7 @@ import '../assets/css/flexstyles.scss';
import Dashboard, { pageClassOn } from './clientUtils';
import ServerConnections from '../components/ServerConnections';
import Headroom from 'headroom.js';
+import { getParameterByName } from '../utils/url.ts';
/* eslint-disable indent */
diff --git a/src/scripts/site.js b/src/scripts/site.js
index 263fed80d2..b346e7dcc7 100644
--- a/src/scripts/site.js
+++ b/src/scripts/site.js
@@ -41,35 +41,6 @@ import SyncPlayHtmlAudioPlayer from '../components/syncPlay/ui/players/HtmlAudio
import { currentSettings } from './settings/userSettings';
import taskButton from './taskbutton';
-// TODO: Move this elsewhere
-window.getWindowLocationSearch = function(win) {
- let search = (win || window).location.search;
-
- if (!search) {
- const index = window.location.href.indexOf('?');
-
- if (index != -1) {
- search = window.location.href.substring(index);
- }
- }
-
- return search || '';
-};
-
-// TODO: Move this elsewhere
-window.getParameterByName = function(name, url) {
- name = name.replace(/[[]/, '\\[').replace(/[\]]/, '\\]');
- const regexS = '[\\?&]' + name + '=([^]*)';
- const regex = new RegExp(regexS, 'i');
- const results = regex.exec(url || getWindowLocationSearch());
-
- if (results == null) {
- return '';
- }
-
- return decodeURIComponent(results[1].replace(/\+/g, ' '));
-};
-
function loadCoreDictionary() {
const languages = ['af', 'ar', 'be-by', 'bg-bg', 'bn_bd', 'ca', 'cs', 'da', 'de', 'el', 'en-gb', 'en-us', 'eo', 'es', 'es-419', 'es-ar', 'es_do', 'es-mx', 'fa', 'fi', 'fil', 'fr', 'fr-ca', 'gl', 'gsw', 'he', 'hi-in', 'hr', 'hu', 'id', 'it', 'ja', 'kk', 'ko', 'lt-lt', 'mr', 'ms', 'nb', 'nl', 'pl', 'pr', 'pt', 'pt-br', 'pt-pt', 'ro', 'ru', 'sk', 'sl-si', 'sq', 'sv', 'ta', 'th', 'tr', 'uk', 'ur_pk', 'vi', 'zh-cn', 'zh-hk', 'zh-tw'];
const translations = languages.map(function (language) {
diff --git a/src/utils/url.ts b/src/utils/url.ts
new file mode 100644
index 0000000000..637f22fed8
--- /dev/null
+++ b/src/utils/url.ts
@@ -0,0 +1,8 @@
+export const getParameterByName = (name: string, url?: string | null | undefined) => {
+ if (!url) {
+ url = window.location.search;
+ }
+
+ // eslint-disable-next-line compat/compat
+ return new URLSearchParams(url).get(name) || '';
+};