Merge pull request #971 from lfoust/externalid-type

Display specific types for ExternalIds

src/components/itemidentifier/itemidentifier.js

@@ -296,8 +296,6 @@ define(["dialogHelper", "loading", "connectionManager", "require", "globalize",
 
             var html = "";
 
-            var providerIds = item.ProviderIds || {};
-
             for (var i = 0, length = idList.length; i < length; i++) {
 
                 var idInfo = idList[i];
@@ -306,9 +304,12 @@ define(["dialogHelper", "loading", "connectionManager", "require", "globalize",
 
                 html += '<div class="inputContainer">';
 
-                var idLabel = globalize.translate("LabelDynamicExternalId").replace("{0}", idInfo.Name);
+                var fullName = idInfo.Name;
+                if (idInfo.Type) {
+                    fullName = idInfo.Name + " " + globalize.translate(idInfo.Type);
+                }
 
-                var value = providerIds[idInfo.Key] || "";
+                var idLabel = globalize.translate("LabelDynamicExternalId").replace("{0}", fullName);
 
                 html += '<input is="emby-input" class="txtLookupId" data-providerkey="' + idInfo.Key + '" id="' + id + '" label="' + idLabel + '"/>';
 

src/components/metadataeditor/metadataeditor.js

@@ -465,7 +465,12 @@ define(['itemHelper', 'dom', 'layoutManager', 'dialogHelper', 'datetime', 'loadi
             var id = "txt1" + idInfo.Key;
             var formatString = idInfo.UrlFormatString || '';
 
-            var labelText = globalize.translate('LabelDynamicExternalId').replace('{0}', idInfo.Name);
+            var fullName = idInfo.Name;
+            if (idInfo.Type) {
+                fullName = idInfo.Name + " " + globalize.translate(idInfo.Type);
+            }
+
+            var labelText = globalize.translate("LabelDynamicExternalId").replace("{0}", fullName);
 
             html += '<div class="inputContainer">';
             html += '<div class="flex align-items-center">';

src/strings/en-us.json

@@ -11,6 +11,8 @@
     "AdditionalNotificationServices": "Browse the plugin catalog to install additional notification services.",
     "AirDate": "Air date",
     "Aired": "Aired",
+    "Album": "Album",
+    "AlbumArtist": "Album Artist",
     "Albums": "Albums",
     "Alerts": "Alerts",
     "All": "All",
@@ -35,6 +37,7 @@
     "Anytime": "Anytime",
     "AroundTime": "Around {0}",
     "Art": "Art",
+    "Artist": "Artist",
     "Artists": "Artists",
     "AsManyAsPossible": "As many as possible",
     "Ascending": "Ascending",
@@ -55,6 +58,7 @@
     "BookLibraryHelp": "Audio and text books are supported. Review the {0}book naming guide{1}.",
     "Books": "Books",
     "Box": "Box",
+    "BoxSet": "Box Set",
     "BoxRear": "Box (rear)",
     "Browse": "Browse",
     "BrowsePluginCatalogMessage": "Browse our plugin catalog to view available plugins.",
@@ -234,6 +238,7 @@
     "EnableThemeVideosHelp": "Play theme videos in the background while browsing the library.",
     "Ended": "Ended",
     "EndsAtValue": "Ends at {0}",
+    "Episode": "Episode",
     "Episodes": "Episodes",
     "ErrorAddingListingsToSchedulesDirect": "There was an error adding the lineup to your Schedules Direct account. Schedules Direct only allows a limited number of lineups per account. You may need to log into the Schedules Direct website and remove others listings from your account before proceeding.",
     "ErrorAddingMediaPathToVirtualFolder": "There was an error adding the media path. Please ensure the path is valid and the Jellyfin Server process has access to that location.",
@@ -1016,6 +1021,7 @@
     "MoveLeft": "Move left",
     "MoveRight": "Move right",
     "MovieLibraryHelp": "Review the {0}movie naming guide{1}.",
+    "Movie": "Movie",
     "Movies": "Movies",
     "MusicAlbum": "Music Album",
     "MusicArtist": "Music Artist",
@@ -1202,6 +1208,7 @@
     "OptionWeekends": "Weekends",
     "OptionWeekly": "Weekly",
     "OriginalAirDateValue": "Original air date: {0}",
+    "OtherArtist": "Other Artist",
     "Overview": "Overview",
     "PackageInstallCancelled": "{0} installation cancelled.",
     "PackageInstallCompleted": "{0} installation completed.",
@@ -1215,6 +1222,7 @@
     "PasswordSaved": "Password saved.",
     "People": "People",
     "PerfectMatch": "Perfect match",
+    "Person": "Person",
     "Photos": "Photos",
     "PictureInPicture": "Picture in picture",
     "PinCodeResetComplete": "The pin code has been reset.",
@@ -1268,6 +1276,7 @@
     "RefreshMetadata": "Refresh metadata",
     "RefreshQueued": "Refresh queued.",
     "ReleaseDate": "Release date",
+    "ReleaseGroup": "Release Group",
     "RememberMe": "Remember me",
     "RemoveFromCollection": "Remove from collection",
     "RemoveFromPlaylist": "Remove from playlist",
@@ -1298,6 +1307,7 @@
     "SearchForMissingMetadata": "Search for missing metadata",
     "SearchForSubtitles": "Search for Subtitles",
     "SearchResults": "Search Results",
+    "Season": "Season",
     "SelectAdminUsername": "Please select a username for the admin account.",
     "SendMessage": "Send message",
     "Series": "Series",
@@ -1413,6 +1423,7 @@
     "TitleHardwareAcceleration": "Hardware Acceleration",
     "TitleHostingSettings": "Hosting Settings",
     "TitlePlayback": "Playback",
+    "Track": "Track",
     "TrackCount": "{0} tracks",
     "Trailers": "Trailers",
     "Transcoding": "Transcoding",