From 94988219d32d23c684a1978ba378b09de738a653 Mon Sep 17 00:00:00 2001
From: Luke Pulverenti <luke.pulverenti@gmail.com>
Date: Fri, 6 Feb 2015 00:59:55 -0500
Subject: [PATCH] fix detail image links

---
 dashboard-ui/itembynamedetails.html    |  4 ++--
 dashboard-ui/scripts/librarybrowser.js | 22 +++++++++++++++-------
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/dashboard-ui/itembynamedetails.html b/dashboard-ui/itembynamedetails.html
index 9386d9fad2..67befae75c 100644
--- a/dashboard-ui/itembynamedetails.html
+++ b/dashboard-ui/itembynamedetails.html
@@ -141,7 +141,7 @@
                         <div class="detailButtonsContainer desktopDetailButtons" style="text-align: left;">
                             <button class="btnPlay hide" type="button" data-icon="play" data-inline="true" data-mini="true">${ButtonPlay}</button>
                             <a class="btnSync hide" data-role="button" data-icon="cloud" data-inline="true" data-mini="true" href="#">${ButtonSync}</a>
-                            <button class="btnMoreCommands hide" type="button" data-icon="ellipsis-v" data-inline="true" data-mini="true">${ButtonMore}</button>
+                            <button class="btnMoreCommands hide jqmButtonNoText" type="button" data-icon="ellipsis-v" data-inline="true" data-mini="true" data-iconpos="notext">${ButtonMore}</button>
                         </div>
                     </td>
                 </tr>
@@ -150,7 +150,7 @@
         <div class="detailButtonsContainer mobileDetailButtons">
             <button class="btnPlay hide" type="button" data-icon="play" data-inline="true" data-mini="true">${ButtonPlay}</button>
             <a class="btnSync hide" data-role="button" data-icon="cloud" data-inline="true" data-mini="true" href="#">${ButtonSync}</a>
-            <button class="btnMoreCommands hide" type="button" data-icon="ellipsis-v" data-inline="true" data-mini="true">${ButtonMore}</button>
+            <button class="btnMoreCommands hide jqmButtonNoText" type="button" data-icon="ellipsis-v" data-inline="true" data-mini="true" data-iconpos="notext">${ButtonMore}</button>
         </div>
         <p class="itemOverview mobileOverview"></p>
         <div data-role="content" style="padding-top: 0;">
diff --git a/dashboard-ui/scripts/librarybrowser.js b/dashboard-ui/scripts/librarybrowser.js
index 4011981710..07bdea04fc 100644
--- a/dashboard-ui/scripts/librarybrowser.js
+++ b/dashboard-ui/scripts/librarybrowser.js
@@ -2203,12 +2203,16 @@
                 url = "css/images/items/detail/video.png";
             }
 
-            if (!href) {
-                href = "#";
+            html += '<div style="position:relative;">';
+
+            if (href) {
+                html += "<a class='itemDetailGalleryLink' href='" + href + "'>";
             }
 
-            html += '<div style="position:relative;">';
             html += "<img class='itemDetailImage' src='" + url + "' />";
+            if (href) {
+                html += "</a>";
+            }
 
             var progressHtml = item.IsFolder ? '' : LibraryBrowser.getItemProgressBarHtml((item.Type == 'Recording' ? item : item.UserData));
 
@@ -2318,12 +2322,12 @@
                 shape = 'square';
             }
 
-            if (!href) {
-                href = "#";
-            }
-
             html += '<div style="position:relative;">';
 
+            if (href) {
+                html += "<a class='itemDetailGalleryLink' href='" + href + "'>";
+            }
+
             if (detectRatio && item.PrimaryImageAspectRatio) {
 
                 if (item.PrimaryImageAspectRatio >= 1.48) {
@@ -2335,6 +2339,10 @@
 
             html += "<img class='itemDetailImage' src='" + url + "' />";
 
+            if (href) {
+                html += "</a>";
+            }
+
             var progressHtml = item.IsFolder ? '' : LibraryBrowser.getItemProgressBarHtml((item.Type == 'Recording' ? item : item.UserData));
 
             if (progressHtml) {