Merge pull request #3536 from thornbill/remove-router-set-title

src/components/appRouter.js

@@ -715,10 +715,6 @@ class AppRouter {
         Dashboard.navigate('home.html?tab=1');
     }
 
-    setTitle(title) {
-        LibraryMenu.setTitle(title);
-    }
-
     getRouteUrl(item, options) {
         if (!item) {
             throw new Error('item cannot be null');

src/components/tabbedview/tabbedview.js

@@ -2,7 +2,7 @@ import backdrop from '../backdrop/backdrop';
 import * as mainTabsManager from '../maintabsmanager';
 import layoutManager from '../layoutManager';
 import '../../elements/emby-tabs/emby-tabs';
-import { appRouter } from '../appRouter';
+import LibraryMenu from '../../scripts/libraryMenu';
 
 function onViewDestroy() {
     const tabControllers = this.tabControllers;
@@ -105,8 +105,9 @@ class TabbedView {
             currentTabController.onPause();
         }
     }
+
     setTitle() {
-        appRouter.setTitle('');
+        LibraryMenu.setTitle('');
     }
 }
 

src/controllers/home.js

@@ -3,7 +3,7 @@ import globalize from '../scripts/globalize';
 import '../elements/emby-tabs/emby-tabs';
 import '../elements/emby-button/emby-button';
 import '../elements/emby-scroller/emby-scroller';
-import { appRouter } from '../components/appRouter';
+import LibraryMenu from '../scripts/libraryMenu';
 
 class HomeView extends TabbedView {
     constructor(view, params) {
@@ -11,7 +11,7 @@ class HomeView extends TabbedView {
     }
 
     setTitle() {
-        appRouter.setTitle(null);
+        LibraryMenu.setTitle(null);
     }
 
     onPause() {

src/controllers/itemDetails/index.js

@@ -571,7 +571,7 @@ function renderDetailPageBackdrop(page, item, apiClient) {
 function reloadFromItem(instance, page, params, item, user) {
     const apiClient = ServerConnections.getApiClient(item.ServerId);
 
-    appRouter.setTitle('');
+    libraryMenu.setTitle('');
 
     // Start rendering the artwork first
     renderImage(page, item);
@@ -2042,7 +2042,7 @@ export default function (view, params) {
 
             if (e.detail.isRestored) {
                 if (currentItem) {
-                    appRouter.setTitle('');
+                    libraryMenu.setTitle('');
                     renderTrackSelections(page, self, currentItem, true);
                     renderBackdrop(currentItem);
                 }

src/controllers/list.js

@@ -11,7 +11,7 @@ import AlphaPicker from '../components/alphaPicker/alphaPicker';
 import '../elements/emby-itemscontainer/emby-itemscontainer';
 import '../elements/emby-scroller/emby-scroller';
 import ServerConnections from '../components/ServerConnections';
-import { appRouter } from '../components/appRouter';
+import LibraryMenu from '../scripts/libraryMenu';
 
 /* eslint-disable indent */
 
@@ -635,7 +635,7 @@ class ItemsView {
         }
 
         function setTitle(item) {
-            appRouter.setTitle(getTitle(item) || '');
+            LibraryMenu.setTitle(getTitle(item) || '');
 
             if (item && item.CollectionType === 'playlists') {
                 hideOrShowAll(view.querySelectorAll('.btnNewItem'), false);

src/controllers/playback/video/index.js

@@ -23,6 +23,7 @@ import ServerConnections from '../../../components/ServerConnections';
 import shell from '../../../scripts/shell';
 import SubtitleSync from '../../../components/subtitlesync/subtitlesync';
 import { appRouter } from '../../../components/appRouter';
+import LibraryMenu from '../../../scripts/libraryMenu';
 
 /* eslint-disable indent */
 
@@ -150,7 +151,7 @@ import { appRouter } from '../../../components/appRouter';
             currentItem = item;
             if (!item) {
                 updateRecordingButton(null);
-                appRouter.setTitle('');
+                LibraryMenu.setTitle('');
                 nowPlayingVolumeSlider.disabled = true;
                 nowPlayingPositionSlider.disabled = true;
                 btnFastForward.disabled = true;
@@ -206,7 +207,7 @@ import { appRouter } from '../../../components/appRouter';
                 itemName = parentName || '';
             }
 
-            appRouter.setTitle(itemName);
+            LibraryMenu.setTitle(itemName);
 
             const documentTitle = parentName || (item ? item.Name : null);
 

src/controllers/session/selectServer/index.js

@@ -196,7 +196,7 @@ import cardBuilder from '../../../components/cardbuilder/cardBuilder';
         updatePageStyle(view, params);
         view.addEventListener('viewshow', function (e) {
             const isRestored = e.detail.isRestored;
-            appRouter.setTitle(null);
+            libraryMenu.setTitle(null);
             libraryMenu.setTransparentMenu(true);
 
             if (!isRestored) {