Change to drop-down for embed sub options

This commit is contained in:
Matthew Jones 2022-01-26 20:38:41 +00:00
parent f426eb68c0
commit 424b4fb976
4 changed files with 25 additions and 15 deletions

View File

@ -412,9 +412,9 @@ import template from './libraryoptionseditor.template.html';
} }
if (contentType === 'tvshows' || contentType === 'movies' || contentType === 'musicvideos' || contentType === 'mixed') { if (contentType === 'tvshows' || contentType === 'movies' || contentType === 'musicvideos' || contentType === 'mixed') {
parent.querySelector('.chkDisableEmbeddedSubtitlesContainer').classList.remove('hide'); parent.querySelector('.fldAllowEmbeddedSubtitlesContainer').classList.remove('hide');
} else { } else {
parent.querySelector('.chkDisableEmbeddedSubtitlesContainer').classList.add('hide'); parent.querySelector('.fldAllowEmbeddedSubtitlesContainer').classList.add('hide');
} }
parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies'); parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies');
@ -515,7 +515,7 @@ import template from './libraryoptionseditor.template.html';
AutomaticRefreshIntervalDays: parseInt(parent.querySelector('#selectAutoRefreshInterval').value), AutomaticRefreshIntervalDays: parseInt(parent.querySelector('#selectAutoRefreshInterval').value),
EnableEmbeddedTitles: parent.querySelector('#chkEnableEmbeddedTitles').checked, EnableEmbeddedTitles: parent.querySelector('#chkEnableEmbeddedTitles').checked,
EnableEmbeddedEpisodeInfos: parent.querySelector('#chkEnableEmbeddedEpisodeInfos').checked, EnableEmbeddedEpisodeInfos: parent.querySelector('#chkEnableEmbeddedEpisodeInfos').checked,
DisableEmbeddedSubtitles: parent.querySelector('#chkDisableEmbeddedSubtitles').checked, AllowEmbeddedSubtitles: parent.querySelector('#selectAllowEmbeddedSubtitles').value,
SkipSubtitlesIfEmbeddedSubtitlesPresent: parent.querySelector('#chkSkipIfGraphicalSubsPresent').checked, SkipSubtitlesIfEmbeddedSubtitlesPresent: parent.querySelector('#chkSkipIfGraphicalSubsPresent').checked,
SkipSubtitlesIfAudioTrackMatches: parent.querySelector('#chkSkipIfAudioTrackPresent').checked, SkipSubtitlesIfAudioTrackMatches: parent.querySelector('#chkSkipIfAudioTrackPresent').checked,
SaveSubtitlesWithMedia: parent.querySelector('#chkSaveSubtitlesLocally').checked, SaveSubtitlesWithMedia: parent.querySelector('#chkSaveSubtitlesLocally').checked,
@ -567,8 +567,8 @@ import template from './libraryoptionseditor.template.html';
parent.querySelector('#chkSaveLocal').checked = options.SaveLocalMetadata; parent.querySelector('#chkSaveLocal').checked = options.SaveLocalMetadata;
parent.querySelector('.chkAutomaticallyGroupSeries').checked = options.EnableAutomaticSeriesGrouping; parent.querySelector('.chkAutomaticallyGroupSeries').checked = options.EnableAutomaticSeriesGrouping;
parent.querySelector('#chkEnableEmbeddedTitles').checked = options.EnableEmbeddedTitles; parent.querySelector('#chkEnableEmbeddedTitles').checked = options.EnableEmbeddedTitles;
parent.querySelector('#chkEnableEmbeddedEpisodeInfos').checked = options.EnableEmbeddedEpisodeInfos; parent.querySelector('#chkEnableEmbeddedEpisodeInfos').value = options.EnableEmbeddedEpisodeInfos;
parent.querySelector('#chkDisableEmbeddedSubtitles').checked = options.DisableEmbeddedSubtitles; parent.querySelector("#selectAllowEmbeddedSubtitles").value = options.AllowEmbeddedSubtitles;
parent.querySelector('#chkSkipIfGraphicalSubsPresent').checked = options.SkipSubtitlesIfEmbeddedSubtitlesPresent; parent.querySelector('#chkSkipIfGraphicalSubsPresent').checked = options.SkipSubtitlesIfEmbeddedSubtitlesPresent;
parent.querySelector('#chkSaveSubtitlesLocally').checked = options.SaveSubtitlesWithMedia; parent.querySelector('#chkSaveSubtitlesLocally').checked = options.SaveSubtitlesWithMedia;
parent.querySelector('#chkSkipIfAudioTrackPresent').checked = options.SkipSubtitlesIfAudioTrackMatches; parent.querySelector('#chkSkipIfAudioTrackPresent').checked = options.SkipSubtitlesIfAudioTrackMatches;

View File

@ -30,12 +30,14 @@
</label> </label>
<div class="fieldDescription checkboxFieldDescription">${PreferEmbeddedEpisodeInfosOverFileNamesHelp}</div> <div class="fieldDescription checkboxFieldDescription">${PreferEmbeddedEpisodeInfosOverFileNamesHelp}</div>
</div> </div>
<div class="checkboxContainer checkboxContainer-withDescription chkDisableEmbeddedSubtitlesContainer hide advanced"> <div class="selectContainer fldAllowEmbeddedSubtitlesContainer hide advanced" style="margin: 2em 0;">
<label> <select is="emby-select" id="selectAllowEmbeddedSubtitles" label="${AllowEmbeddedSubtitles}">
<input is="emby-checkbox" type="checkbox" id="chkDisableEmbeddedSubtitles" /> <option value="AllowAll">${AllowEmbeddedSubtitlesAllowAllOption}</option>
<span>${DisableEmbeddedSubtitles}</span> <option value="AllowText">${AllowEmbeddedSubtitlesAllowTextOption}</option>
</label> <option value="AllowImage">${AllowEmbeddedSubtitlesAllowImageOption}</option>
<div class="fieldDescription checkboxFieldDescription">${DisableEmbeddedSubtitlesHelp}</div> <option value="AllowNone">${AllowEmbeddedSubtitlesAllowNoneOption}</option>
</select>
<div class="fieldDescription">${AllowEmbeddedSubtitlesHelp}</div>
</div> </div>
<div class="checkboxContainer checkboxContainer-withDescription advanced"> <div class="checkboxContainer checkboxContainer-withDescription advanced">

View File

@ -1266,8 +1266,12 @@
"Season": "Series", "Season": "Series",
"PreferEmbeddedEpisodeInfosOverFileNames": "Prefer embedded episode information over filenames", "PreferEmbeddedEpisodeInfosOverFileNames": "Prefer embedded episode information over filenames",
"PreferEmbeddedEpisodeInfosOverFileNamesHelp": "Use the episode information from the embedded metadata if available.", "PreferEmbeddedEpisodeInfosOverFileNamesHelp": "Use the episode information from the embedded metadata if available.",
"DisableEmbeddedSubtitles": "Disable embedded subtitles", "AllowEmbeddedSubtitles": "Disable different types of embedded subtitles",
"DisableEmbeddedSubtitlesHelp": "Disable subtitles that are packaged within media containers.", "AllowEmbeddedSubtitlesHelp": "Disable subtitles that are packaged within media containers. Requires a full library refresh.",
"AllowEmbeddedSubtitlesAllowAllOption": "Allow All",
"AllowEmbeddedSubtitlesAllowNoneOption": "Allow None",
"AllowEmbeddedSubtitlesAllowImageOption": "Allow Image",
"AllowEmbeddedSubtitlesAllowTextOption": "Allow Text",
"Person": "Person", "Person": "Person",
"Movie": "Film", "Movie": "Film",
"LabelLibraryPageSizeHelp": "Set the amount of items to show on a library page. Set to 0 in order to disable paging.", "LabelLibraryPageSizeHelp": "Set the amount of items to show on a library page. Set to 0 in order to disable paging.",

View File

@ -1288,8 +1288,12 @@
"PreferEmbeddedEpisodeInfosOverFileNamesHelp": "Use the episode information from the embedded metadata if available.", "PreferEmbeddedEpisodeInfosOverFileNamesHelp": "Use the episode information from the embedded metadata if available.",
"PreferEmbeddedTitlesOverFileNames": "Prefer embedded titles over filenames", "PreferEmbeddedTitlesOverFileNames": "Prefer embedded titles over filenames",
"PreferEmbeddedTitlesOverFileNamesHelp": "Determine the display title to use when no internet metadata or local metadata is available.", "PreferEmbeddedTitlesOverFileNamesHelp": "Determine the display title to use when no internet metadata or local metadata is available.",
"DisableEmbeddedSubtitles": "Disable embedded subtitles", "AllowEmbeddedSubtitles": "Disable different types of embedded subtitles",
"DisableEmbeddedSubtitlesHelp": "Disable subtitles that are packaged within media containers.", "AllowEmbeddedSubtitlesHelp": "Disable subtitles that are packaged within media containers. Requires a full library refresh.",
"AllowEmbeddedSubtitlesAllowAllOption": "Allow All",
"AllowEmbeddedSubtitlesAllowNoneOption": "Allow None",
"AllowEmbeddedSubtitlesAllowImageOption": "Allow Image",
"AllowEmbeddedSubtitlesAllowTextOption": "Allow Text",
"Premiere": "Premiere", "Premiere": "Premiere",
"Premieres": "Premieres", "Premieres": "Premieres",
"Preview": "Preview", "Preview": "Preview",