From 3b5e5cf7cff2d7e76bd3b1089203cd0e4c51df14 Mon Sep 17 00:00:00 2001 From: Cromefire_ Date: Mon, 27 Apr 2020 14:20:32 +0200 Subject: [PATCH] Fixed code smell and removed plugin helper --- src/components/pluginManager.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/components/pluginManager.js b/src/components/pluginManager.js index 28677178f8..c87dc003ed 100644 --- a/src/components/pluginManager.js +++ b/src/components/pluginManager.js @@ -4,7 +4,7 @@ define(['events', 'globalize', 'appRouter'], function (events, globalize, appRou // TODO: replace with each plugin version var cacheParam = new Date().getTime(); - function loadStrings(plugin, globalize) { + function loadStrings(plugin) { var strings = plugin.getTranslations ? plugin.getTranslations() : []; return globalize.loadStrings({ name: plugin.id || plugin.packageName, @@ -44,7 +44,7 @@ define(['events', 'globalize', 'appRouter'], function (events, globalize, appRou return Promise.resolve(plugin); } else { return new Promise((resolve, reject) => { - loadStrings(plugin, globalize) + loadStrings(plugin) .then(function () { resolve(plugin); }) @@ -95,8 +95,7 @@ define(['events', 'globalize', 'appRouter'], function (events, globalize, appRou }); } else if (pluginSpec.then) { return pluginSpec.then(pluginBuilder => { - const pluginHelper = {}; // TODO: Advance this - return pluginBuilder(pluginHelper); + return pluginBuilder(); }).then(plugin => { return registerPlugin(plugin); });