mirror of
https://github.com/immich-app/immich.git
synced 2024-11-17 10:58:53 -07:00
7173af60e4
* tests for person service * tests for auth service * tests for access core * improve tests for album service * fix missing brackets and remove comments * tests for asset service * tests for face recognition * tests for job service * feedback * tests for search service (broken) * fix: disabled search test * tests for smart-info service * tests for storage template service * tests for user service * fix formatting of untouched files LOL * attempt to fix formatting * streamline api utils, add asset api for uploading files * test upload of assets * fix formatting * move test-utils to correct folder * test add assets to album * use random bytes instead of test image * (e2e) test albums with assets * (e2e) complete tests for album endpoints * (e2e) tests for asset endpoint * fix: asset upload/import dto validation * (e2e) tests for statistics asset endpoint * fix wrong describe text * (e2e) tests for people with faces * (e2e) clean up person tests * (e2e) tests for partner sharing endpoints * (e2e) tests for link sharing * (e2e) tests for the asset time bucket endpoint * fix minor issues * remove access.core.spec.ts * chore: wording * chore: organize test api files * chore: fix test describe * implement feedback * fix race condition in album tests --------- Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
181 lines
6.0 KiB
TypeScript
181 lines
6.0 KiB
TypeScript
import { IFaceRepository, IPersonRepository, LoginResponseDto } from '@app/domain';
|
|
import { AppModule, PersonController } from '@app/immich';
|
|
import { PersonEntity } from '@app/infra/entities';
|
|
import { INestApplication } from '@nestjs/common';
|
|
import { Test, TestingModule } from '@nestjs/testing';
|
|
import { api } from '@test/api';
|
|
import { db } from '@test/db';
|
|
import { errorStub, uuidStub } from '@test/fixtures';
|
|
import request from 'supertest';
|
|
|
|
describe(`${PersonController.name}`, () => {
|
|
let app: INestApplication;
|
|
let server: any;
|
|
let loginResponse: LoginResponseDto;
|
|
let accessToken: string;
|
|
let personRepository: IPersonRepository;
|
|
let faceRepository: IFaceRepository;
|
|
let visiblePerson: PersonEntity;
|
|
let hiddenPerson: PersonEntity;
|
|
|
|
beforeAll(async () => {
|
|
const moduleFixture: TestingModule = await Test.createTestingModule({
|
|
imports: [AppModule],
|
|
}).compile();
|
|
|
|
app = await moduleFixture.createNestApplication().init();
|
|
server = app.getHttpServer();
|
|
personRepository = app.get<IPersonRepository>(IPersonRepository);
|
|
faceRepository = app.get<IFaceRepository>(IFaceRepository);
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await db.reset();
|
|
await api.authApi.adminSignUp(server);
|
|
loginResponse = await api.authApi.adminLogin(server);
|
|
accessToken = loginResponse.accessToken;
|
|
|
|
const faceAsset = await api.assetApi.upload(server, accessToken, 'face_asset');
|
|
visiblePerson = await personRepository.create({
|
|
ownerId: loginResponse.userId,
|
|
name: 'visible_person',
|
|
thumbnailPath: '/thumbnail/face_asset',
|
|
});
|
|
await faceRepository.create({ assetId: faceAsset.id, personId: visiblePerson.id });
|
|
|
|
hiddenPerson = await personRepository.create({
|
|
ownerId: loginResponse.userId,
|
|
name: 'hidden_person',
|
|
isHidden: true,
|
|
thumbnailPath: '/thumbnail/face_asset',
|
|
});
|
|
await faceRepository.create({ assetId: faceAsset.id, personId: hiddenPerson.id });
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await db.disconnect();
|
|
await app.close();
|
|
});
|
|
|
|
describe('GET /person', () => {
|
|
beforeEach(async () => {});
|
|
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).get('/person');
|
|
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
it('should return all people (including hidden)', async () => {
|
|
const { status, body } = await request(server)
|
|
.get('/person')
|
|
.set('Authorization', `Bearer ${accessToken}`)
|
|
.query({ withHidden: true });
|
|
|
|
expect(status).toBe(200);
|
|
expect(body).toEqual({
|
|
total: 2,
|
|
visible: 1,
|
|
people: [
|
|
expect.objectContaining({ name: 'visible_person' }),
|
|
expect.objectContaining({ name: 'hidden_person' }),
|
|
],
|
|
});
|
|
});
|
|
|
|
it('should return only visible people', async () => {
|
|
const { status, body } = await request(server).get('/person').set('Authorization', `Bearer ${accessToken}`);
|
|
|
|
expect(status).toBe(200);
|
|
expect(body).toEqual({
|
|
total: 1,
|
|
visible: 1,
|
|
people: [expect.objectContaining({ name: 'visible_person' })],
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('GET /person/:id', () => {
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).get(`/person/${uuidStub.notFound}`);
|
|
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
it('should throw error if person with id does not exist', async () => {
|
|
const { status, body } = await request(server)
|
|
.get(`/person/${uuidStub.notFound}`)
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
|
|
expect(status).toBe(400);
|
|
expect(body).toEqual(errorStub.badRequest);
|
|
});
|
|
|
|
it('should return person information', async () => {
|
|
const { status, body } = await request(server)
|
|
.get(`/person/${visiblePerson.id}`)
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
|
|
expect(status).toBe(200);
|
|
expect(body).toEqual(expect.objectContaining({ id: visiblePerson.id }));
|
|
});
|
|
});
|
|
|
|
describe('PUT /person/:id', () => {
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).put(`/person/${uuidStub.notFound}`);
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
for (const key of ['name', 'featureFaceAssetId', 'isHidden']) {
|
|
it(`should not allow null ${key}`, async () => {
|
|
const { status, body } = await request(server)
|
|
.put(`/person/${visiblePerson.id}`)
|
|
.set('Authorization', `Bearer ${accessToken}`)
|
|
.send({ [key]: null });
|
|
expect(status).toBe(400);
|
|
expect(body).toEqual(errorStub.badRequest);
|
|
});
|
|
}
|
|
|
|
it('should not accept invalid birth dates', async () => {
|
|
for (const birthDate of [false, 'false', '123567', 123456]) {
|
|
const { status, body } = await request(server)
|
|
.put(`/person/${uuidStub.notFound}`)
|
|
.set('Authorization', `Bearer ${accessToken}`)
|
|
.send({ birthDate });
|
|
expect(status).toBe(400);
|
|
expect(body).toEqual(errorStub.badRequest);
|
|
}
|
|
});
|
|
|
|
it('should update a date of birth', async () => {
|
|
const { status, body } = await request(server)
|
|
.put(`/person/${visiblePerson.id}`)
|
|
.set('Authorization', `Bearer ${accessToken}`)
|
|
.send({ birthDate: '1990-01-01T05:00:00.000Z' });
|
|
expect(status).toBe(200);
|
|
expect(body).toMatchObject({ birthDate: '1990-01-01' });
|
|
});
|
|
|
|
it('should clear a date of birth', async () => {
|
|
const person = await personRepository.create({
|
|
birthDate: new Date('1990-01-01'),
|
|
ownerId: loginResponse.userId,
|
|
});
|
|
|
|
expect(person.birthDate).toBeDefined();
|
|
|
|
const { status, body } = await request(server)
|
|
.put(`/person/${person.id}`)
|
|
.set('Authorization', `Bearer ${accessToken}`)
|
|
.send({ birthDate: null });
|
|
expect(status).toBe(200);
|
|
expect(body).toMatchObject({ birthDate: null });
|
|
});
|
|
});
|
|
});
|