mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2024-11-17 19:08:25 -07:00
8fdd789474
Updates #3419.
Squashed commit of the following:
commit 370094c00d9c15b1336fbedb1e233bd4436c9898
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Fri Sep 10 17:31:16 2021 +0300
added link to github issue
commit 407ba9b2db46b887a30ddb081bd37c56e56b0496
Merge: 426c8146 80548233
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Fri Sep 10 17:29:52 2021 +0300
Merge branch 'master' into 3419-client-allowlist-collision
commit 426c8146cff5c112ebb25192af276c6601200528
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Fri Sep 10 16:28:11 2021 +0300
fix en
commit d28c6022321828c6bdc55c3f9a4f655b26d146d2
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Fri Sep 10 15:49:12 2021 +0300
added missing space
commit b374a09327968ca5343c1595d1ab8cf317c15ffe
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Fri Sep 10 15:43:55 2021 +0300
fixes after review
commit 2be629d66e4703e2f5a85615bf1eaaa92e03c6fd
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Thu Sep 9 14:17:19 2021 +0300
fixes
commit 5c2aa6201cc0ecf404d4057e354fbb0bdadcdd6d
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Wed Sep 8 15:04:30 2021 +0300
return empty line to locale file
commit 3631c3772babbd595b1c3de4a7e91be6bac3e80f
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date: Wed Sep 8 13:57:51 2021 +0300
all: fix collisions in access lists && expand block/unblock client
291 lines
7.0 KiB
Go
291 lines
7.0 KiB
Go
package dnsforward
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/AdguardTeam/golibs/errors"
|
|
"github.com/AdguardTeam/golibs/log"
|
|
"github.com/AdguardTeam/golibs/netutil"
|
|
"github.com/AdguardTeam/golibs/stringutil"
|
|
"github.com/AdguardTeam/urlfilter"
|
|
"github.com/AdguardTeam/urlfilter/filterlist"
|
|
)
|
|
|
|
// accessCtx controls IP and client blocking that takes place before all other
|
|
// processing. An accessCtx is safe for concurrent use.
|
|
type accessCtx struct {
|
|
allowedIPs *netutil.IPMap
|
|
blockedIPs *netutil.IPMap
|
|
|
|
allowedClientIDs *stringutil.Set
|
|
blockedClientIDs *stringutil.Set
|
|
|
|
blockedHostsEng *urlfilter.DNSEngine
|
|
|
|
// TODO(a.garipov): Create a type for a set of IP networks.
|
|
// netutil.IPNetSet?
|
|
allowedNets []*net.IPNet
|
|
blockedNets []*net.IPNet
|
|
}
|
|
|
|
// unit is a convenient alias for struct{}
|
|
type unit = struct{}
|
|
|
|
// processAccessClients is a helper for processing a list of client strings,
|
|
// which may be an IP address, a CIDR, or a ClientID.
|
|
func processAccessClients(
|
|
clientStrs []string,
|
|
ips *netutil.IPMap,
|
|
nets *[]*net.IPNet,
|
|
clientIDs *stringutil.Set,
|
|
) (err error) {
|
|
for i, s := range clientStrs {
|
|
if ip := net.ParseIP(s); ip != nil {
|
|
ips.Set(ip, unit{})
|
|
} else if cidrIP, ipnet, cidrErr := net.ParseCIDR(s); cidrErr == nil {
|
|
ipnet.IP = cidrIP
|
|
*nets = append(*nets, ipnet)
|
|
} else {
|
|
idErr := ValidateClientID(s)
|
|
if idErr != nil {
|
|
return fmt.Errorf(
|
|
"value %q at index %d: bad ip, cidr, or clientid",
|
|
s,
|
|
i,
|
|
)
|
|
}
|
|
|
|
clientIDs.Add(s)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// newAccessCtx creates a new accessCtx.
|
|
func newAccessCtx(allowed, blocked, blockedHosts []string) (a *accessCtx, err error) {
|
|
a = &accessCtx{
|
|
allowedIPs: netutil.NewIPMap(0),
|
|
blockedIPs: netutil.NewIPMap(0),
|
|
|
|
allowedClientIDs: stringutil.NewSet(),
|
|
blockedClientIDs: stringutil.NewSet(),
|
|
}
|
|
|
|
err = processAccessClients(allowed, a.allowedIPs, &a.allowedNets, a.allowedClientIDs)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("adding allowed: %w", err)
|
|
}
|
|
|
|
err = processAccessClients(blocked, a.blockedIPs, &a.blockedNets, a.blockedClientIDs)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("adding blocked: %w", err)
|
|
}
|
|
|
|
b := &strings.Builder{}
|
|
for _, h := range blockedHosts {
|
|
stringutil.WriteToBuilder(b, strings.ToLower(h), "\n")
|
|
}
|
|
|
|
lists := []filterlist.RuleList{
|
|
&filterlist.StringRuleList{
|
|
ID: int(0),
|
|
RulesText: b.String(),
|
|
IgnoreCosmetic: true,
|
|
},
|
|
}
|
|
|
|
rulesStrg, err := filterlist.NewRuleStorage(lists)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("adding blocked hosts: %w", err)
|
|
}
|
|
|
|
a.blockedHostsEng = urlfilter.NewDNSEngine(rulesStrg)
|
|
|
|
return a, nil
|
|
}
|
|
|
|
// allowlistMode returns true if this *accessCtx is in the allowlist mode.
|
|
func (a *accessCtx) allowlistMode() (ok bool) {
|
|
return a.allowedIPs.Len() != 0 || a.allowedClientIDs.Len() != 0 || len(a.allowedNets) != 0
|
|
}
|
|
|
|
// isBlockedClientID returns true if the ClientID should be blocked.
|
|
func (a *accessCtx) isBlockedClientID(id string) (ok bool) {
|
|
allowlistMode := a.allowlistMode()
|
|
if id == "" {
|
|
// In allowlist mode, consider requests without client IDs
|
|
// blocked by default.
|
|
return allowlistMode
|
|
}
|
|
|
|
if allowlistMode {
|
|
return !a.allowedClientIDs.Has(id)
|
|
}
|
|
|
|
return a.blockedClientIDs.Has(id)
|
|
}
|
|
|
|
// isBlockedHost returns true if host should be blocked.
|
|
func (a *accessCtx) isBlockedHost(host string) (ok bool) {
|
|
_, ok = a.blockedHostsEng.Match(strings.ToLower(host))
|
|
|
|
return ok
|
|
}
|
|
|
|
// isBlockedIP returns the status of the IP address blocking as well as the rule
|
|
// that blocked it.
|
|
func (a *accessCtx) isBlockedIP(ip net.IP) (blocked bool, rule string) {
|
|
blocked = true
|
|
ips := a.blockedIPs
|
|
ipnets := a.blockedNets
|
|
|
|
if a.allowlistMode() {
|
|
// Enable allowlist mode and use the allowlist sets.
|
|
blocked = false
|
|
ips = a.allowedIPs
|
|
ipnets = a.allowedNets
|
|
}
|
|
|
|
if _, ok := ips.Get(ip); ok {
|
|
return blocked, ip.String()
|
|
}
|
|
|
|
for _, ipnet := range ipnets {
|
|
if ipnet.Contains(ip) {
|
|
return blocked, ipnet.String()
|
|
}
|
|
}
|
|
|
|
return !blocked, ""
|
|
}
|
|
|
|
type accessListJSON struct {
|
|
AllowedClients []string `json:"allowed_clients"`
|
|
DisallowedClients []string `json:"disallowed_clients"`
|
|
BlockedHosts []string `json:"blocked_hosts"`
|
|
}
|
|
|
|
func (s *Server) accessListJSON() (j accessListJSON) {
|
|
s.serverLock.RLock()
|
|
defer s.serverLock.RUnlock()
|
|
|
|
return accessListJSON{
|
|
AllowedClients: stringutil.CloneSlice(s.conf.AllowedClients),
|
|
DisallowedClients: stringutil.CloneSlice(s.conf.DisallowedClients),
|
|
BlockedHosts: stringutil.CloneSlice(s.conf.BlockedHosts),
|
|
}
|
|
}
|
|
|
|
func (s *Server) handleAccessList(w http.ResponseWriter, r *http.Request) {
|
|
j := s.accessListJSON()
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
err := json.NewEncoder(w).Encode(j)
|
|
if err != nil {
|
|
httpError(r, w, http.StatusInternalServerError, "encoding response: %s", err)
|
|
|
|
return
|
|
}
|
|
}
|
|
|
|
func isUniq(slice []string) (ok bool, uniqueMap map[string]unit) {
|
|
exists := make(map[string]unit)
|
|
for _, key := range slice {
|
|
if _, has := exists[key]; has {
|
|
return false, nil
|
|
}
|
|
exists[key] = unit{}
|
|
}
|
|
return true, exists
|
|
}
|
|
|
|
func intersect(mapA, mapB map[string]unit) bool {
|
|
for key := range mapA {
|
|
if _, has := mapB[key]; has {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// validateAccessSet checks the internal accessListJSON lists. To search for
|
|
// duplicates, we cannot compare the new stringutil.Set and []string, because
|
|
// creating a set for a large array can be an unnecessary algorithmic complexity
|
|
func validateAccessSet(list accessListJSON) (err error) {
|
|
const (
|
|
errAllowedDup errors.Error = "duplicates in allowed clients"
|
|
errDisallowedDup errors.Error = "duplicates in disallowed clients"
|
|
errBlockedDup errors.Error = "duplicates in blocked hosts"
|
|
errIntersect errors.Error = "some items in allowed and " +
|
|
"disallowed lists at the same time"
|
|
)
|
|
|
|
ok, allowedClients := isUniq(list.AllowedClients)
|
|
if !ok {
|
|
return errAllowedDup
|
|
}
|
|
|
|
ok, disallowedClients := isUniq(list.DisallowedClients)
|
|
if !ok {
|
|
return errDisallowedDup
|
|
}
|
|
|
|
ok, _ = isUniq(list.BlockedHosts)
|
|
if !ok {
|
|
return errBlockedDup
|
|
}
|
|
|
|
if intersect(allowedClients, disallowedClients) {
|
|
return errIntersect
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *Server) handleAccessSet(w http.ResponseWriter, r *http.Request) {
|
|
list := accessListJSON{}
|
|
err := json.NewDecoder(r.Body).Decode(&list)
|
|
if err != nil {
|
|
httpError(r, w, http.StatusBadRequest, "decoding request: %s", err)
|
|
|
|
return
|
|
}
|
|
|
|
err = validateAccessSet(list)
|
|
if err != nil {
|
|
httpError(r, w, http.StatusBadRequest, err.Error())
|
|
|
|
return
|
|
}
|
|
|
|
var a *accessCtx
|
|
a, err = newAccessCtx(list.AllowedClients, list.DisallowedClients, list.BlockedHosts)
|
|
if err != nil {
|
|
httpError(r, w, http.StatusBadRequest, "creating access ctx: %s", err)
|
|
|
|
return
|
|
}
|
|
|
|
defer log.Debug(
|
|
"access: updated lists: %d, %d, %d",
|
|
len(list.AllowedClients),
|
|
len(list.DisallowedClients),
|
|
len(list.BlockedHosts),
|
|
)
|
|
|
|
defer s.conf.ConfigModified()
|
|
|
|
s.serverLock.Lock()
|
|
defer s.serverLock.Unlock()
|
|
|
|
s.conf.AllowedClients = list.AllowedClients
|
|
s.conf.DisallowedClients = list.DisallowedClients
|
|
s.conf.BlockedHosts = list.BlockedHosts
|
|
s.access = a
|
|
}
|